Upgrade d3 version #197
Merged
Upgrade d3 version #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
PR looks good in Chrome and Safari. For the record - the changes are backwards-incompatible and throw errors when using d3.js v4. Users are expected to have forked the repo (retaining old version) or to follow README.md and use the versioned artifact. However, I will add a note in a follow-up PR in case folks experience errors when using unversioned radar.js with old d3.js version. I verified that |
|
👍 |
|
Might be interesting to publish this as an ESM package on npm so people don't have to copy paste the script. I, myself, have installed D3 via npm and imported it in my app instead of linking to the CDN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #196